Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HIP debug flags to use -G only for NVIDIA compilers #1518

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jakurzak
Copy link
Contributor

  • Updated CMake configuration to set -g -G only when the HIP compiler is NVIDIA (nvcc).
  • For Clang-based HIP compilers, use -g alone as it supports both host and device debugging.
  • Improved flag descriptions in CMake cache to reflect the specific behavior of each compiler.
  • This ensures compatibility and avoids unsupported flag errors with Clang.

- Updated CMake configuration to set `-g -G` only when the HIP compiler is NVIDIA (`nvcc`).
- For Clang-based HIP compilers, use `-g` alone as it supports both host and device debugging.
- Improved flag descriptions in CMake cache to reflect the specific behavior of each compiler.
- This ensures compatibility and avoids unsupported flag errors with Clang.
@jakurzak jakurzak requested a review from a team as a code owner November 18, 2024 20:30
Copy link
Member

@maddyscientist maddyscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jakurzak

@maddyscientist maddyscientist merged commit 85ba0cd into lattice:develop Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants