Add meson option to disable explicit EC keys tests #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Mulling <[email protected]>
Signed-off-by: Lucas Mulling <[email protected]>
Mulling
changed the title
|
Should we make it the other way round and disable the explicit curves by default and enable them only if some configuration option is provided instead? |
|
Would be better, I think debian is the only one that allows it. |
Signed-off-by: Lucas Mulling <[email protected]>
|
@Jakuje Not sure how you want to handle the workflow config, I just copied what was already done for |
Jakuje
previously approved these changes
Dec 28, 2024
Signed-off-by: Lucas Mulling <[email protected]>
Jakuje
approved these changes
Dec 28, 2024
ueno
reviewed
Dec 30, 2024
| @@ -2,3 +2,8 @@ option('preload_libasan', | |||
| type: 'string', | |||
| value: 'no', | |||
| description: 'Path to libasan.so to preload') | |||
|
|
|||
| option('enable_explicit_EC_test', | |||
There was a problem hiding this comment.
Not sure if this needs to be generic, but meson provides a feature option type for enabled/disabled kind of options.
There was a problem hiding this comment.
Not sure either, I'm guessing it would be more useful if we had a dependency in this case, but since this is just a on-and-off switch I don't see the need for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a meson option to disable explicit EC keys tests.
Checklist
Reviewer's checklist: