Add basic tlsfuzzer tests #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jakuje
force-pushed
the
tlsfuzzer
branch
10 times, most recently
from
327b849 to
078fc6b
Compare
Signed-off-by: Jakub Jelen <[email protected]>
Using latest and rawhide in different jobs caused different cache issues where the rust built code did not work on consequent CI runs. Using only fedora:latest container image should solve this issue. Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
Signed-off-by: Jakub Jelen <[email protected]>
|
I tried to make the test https://github.com/tlsfuzzer/tlsfuzzer/blob/master/scripts/test-tls13-rsapss-signatures.py working too, but got stumped by the RSA-PSS spki identifiers so its not yet done. I just pushed what worked so far. Feel free to merge or wait for follow-up changes hopefully tomorrow. I will also send this PR to Alicja for review. |
tomato42
reviewed
Nov 1, 2024
|
apart from the small issue with the comment, LGTM |
|
Everything seems to be workin, let's merge this one and defer to a follow up (set of) PR(s) to fix the identified issue and add more test cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This integrates tlsfuzzer tests into the pkcs11-provider testsuite.
Right now, the coverage is limited to quite basic operations in the TLS session, but it can be easily extended with existing tlsfuzzer scripts that will add more coverage for various cryptographic algorithms.
So far, the tests did not find any issue.
Checklist
Reviewer's checklist: