Embed the private key with public key attributes. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fabled, could you confirm if this fix works for you when you have time? Thank you! |
sahanaprasad07
force-pushed
the
main
branch
2 times, most recently
from
ee33b17 to
84ee90e
Compare
For RSA: CKA_MODULUS, CKA_PUBLIC_EXPONENT For EC: CKA_EC_POINT, CKA_EC_PARAMS, CKA_P11PROV_PUB_KEY Fixes: latchset#282 Signed-off-by: Sahana Prasad <[email protected]>
Signed-off-by: Sahana Prasad <[email protected]>
sahanaprasad07
force-pushed
the
main
branch
from
84ee90e to
5b74a63
Compare
simo5
approved these changes
Sep 29, 2023
|
LGTM and tests pass! |
manu0x0
pushed a commit
to isc-projects/bind9
that referenced
this pull request
Jan 25, 2024
The pkcs11-provider did not yet support getting X/Y coordinates on newly generated EC PKEY keys, thus we attempted to get the key from the label after it was generated in the keystore. This has been fixed in: latchset/pkcs11-provider#293 Thus now we should be able to use the generated key structure immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After generating a key pair via p11prov_GenerateKeyPair() in p11prov_common_gen(), embed the private key with public key attributes through this new function p11prov_merge_pub_attrs_into_priv().
This would be useful to reconstruct the public key from the private key.
Further, attributes like CKA_P11PROV_PUB_KEY_X and CKA_P11PROV_PUB_KEY_Y can be extracted directly from EC private keys.
The following attributes are copied-
For RSA: CKA_MODULUS, CKA_PUBLIC_EXPONENT
For EC: CKA_EC_POINT, CKA_EC_PARAMS, CKA_P11PROV_PUB_KEY
Fixes #282