Update docker scripts under Windows #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
special casing for windows systems and winpty prefix not needed so long as Docker CLI is on path
special casing for windows systems and winpty prefix not needed so long as Docker CLI is on path
special casing for windows systems and winpty prefix not needed so long as Docker CLI is on path
…ng as Docker CLI is on path
…ng as Docker CLI is on path
|
The "//" are odd, but appear to work on Mac and Linux as well as Windows. |
dinkelk
requested changes
Nov 28, 2023
Removed the ON_WINDOWS case statement in docker_config.sh
Update docker_config.sh
dinkelk
approved these changes
Nov 28, 2023
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update create_container.sh
Update login_container.sh
Update start_container.sh
Special casing for Windows, nor winpty, are not needed so long as docker is on terminal path.