Skip to content

Commit

Permalink
add ok return type
Browse files Browse the repository at this point in the history
Signed-off-by: Alejandro M. Ramallo <[email protected]>
  • Loading branch information
aramallo committed Dec 13, 2024
1 parent c232345 commit 3edb411
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# CHANGELOG
# v5.0.0-rc.14
## Changes
* Add `ok` as valid return for `exchange` callback in `partisan_plumbtree_broadcast_handler`.
# v5.0.0-rc.14
## Fixes
* Fixes the case where `partisan_plumbtree_broadcast` behaviour implementors' callbacks throw an exception which would crash the broadcast server.
* Replace use of RPC in `partisan_plumbtree_broadcast` and use
Expand Down
2 changes: 1 addition & 1 deletion src/partisan.app.src
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
{description,
"Partisan is a scalable and flexible, TCP-based membership system and distribution layer for the BEAM."
},
{vsn, "5.0.0-rc.14"},
{vsn, "5.0.0-rc.15"},
{registered, []},
{applications, [
kernel,
Expand Down
2 changes: 1 addition & 1 deletion src/partisan_plumtree_broadcast_handler.erl
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
%% The exchange does not need to account for messages in-flight when it is
%% started or broadcast during its operation. These can be taken care of in
%% future exchanges.
-callback exchange(node()) -> {ok, pid()} | {error, term()} | ignore.
-callback exchange(node()) -> ok | {ok, pid()} | {error, term()} | ignore.


-optional_callbacks([broadcast_channel/0]).
Expand Down

0 comments on commit 3edb411

Please sign in to comment.