Add vote count field to NewsItem, Issue and Comment models. #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
Open
|
Should I merge this now or are we waiting until step 2 is ready to go? |
|
I think this is ready to commit with the caveat noted above. Unfortunately, the conversation on #328 seemes to have stalled... In keeping with the "community-built site" theme I've suggested these three smaller steps (this implements the first of those), hoping others would chime in on the other parts. If you do apply this we should open a new issue for the data alignment part, and once that's implemented refactoring the scoring code should be fairly simple. |
|
@megamattron Can you merge this? |
megamattron
added a commit
that referenced
this pull request
Jun 1, 2014
Add vote count field to NewsItem, Issue and Comment models.
|
Sorry it took me so long, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request increments a
vote_countfield on NewsItems, Comments and Issues as votes are saved. The idea is to eliminate the need to calculate votes for these items when calculating scores which should greatly improve the performance problems indicated in issue #328 while retaining the ability to dynamically calculate scores.Note that this is only the first step in this proposed solution, and on it's own only begins to aggregate the vote counts for new items. Should we decide to fully implement this we would next need to calculate the vote counts for all existing items and only then could we refine the selection/scoring process to use these new values (as stated in the comments for Issue #328)