Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

At-mentions change to links, and small change to README #306

Merged
merged 3 commits into from
Mar 16, 2014

Conversation

samcal
Copy link
Contributor

@samcal samcal commented Mar 8, 2014

at-mentions will change to a link to '/news/user/<username/' when posting a comment. i also want to change the order of the summary in the readme

people can only log in to the development server when they have an
account, which requires their name to already be in the config file.
@treygriffith
Copy link
Collaborator

Why is the change done at the time that the comment is posting rather than before displaying, or even client-side?

Thanks for the PR!

@megamattron
Copy link
Member

Hi Sam, thanks for the pull request. I think I agree with Trey though that I'd rather not store the links in the actual comments (since the URL to the user profile might change in the future, etc). So maybe we can use your regex to modify the comment text right before posting? Either way we'll get you into the user list, I think it probably just makes sense to change the point at which we apply the regex. Thanks!

@swelham
Copy link
Collaborator

swelham commented Mar 8, 2014

I agree with the above, it should work the same as how the issue numbers are handled - see here

@treygriffith
Copy link
Collaborator

I agree with @swelham, issue parsing is a good model to follow. We should probably start modularizing so we have our own customized markdown parser that's specific to Pullup with issues, mentions, etc.

Just to keep track, if implemented this PR should close #292.

@samcal
Copy link
Contributor Author

samcal commented Mar 8, 2014

Understood. I'll make those adjustments.

@josephwegner
Copy link
Collaborator

Thanks for the PR @samcal!

I'm not a man of authority here, but I bet if you put in a PR adding yourself to the authorized users list, it would get merged. You've proved your chops with this PR, regardless of the decision to go a different direction.

Also, if you need any help with the revisions or need to pass them off, feel free to let us know. I know having a PR turned down can feel discouraging at times - that's certainly not our intention.

@josephwegner josephwegner mentioned this pull request Mar 14, 2014
@megamattron megamattron merged commit dcac63a into larvalabs:master Mar 16, 2014
@megamattron
Copy link
Member

Closing since this is covered in #318 - @samcal you should have access shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants