-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix our legion config to build against our hdf5 #90
Conversation
Is this one of the repos whose CI has been moved to gitlab? |
I looked on gitlab and didn't see it. But even if it's there, there's no reason why this CI shouldn't pass. |
Ok. I didn't know if something had changed to accommodate gitlab that was incompatible with travis. |
Good suggestion, but I don't think that's the issue. |
@cferenba retry? |
@cferenba :did you have to do this changes because of some kind of issues with the FindHDF5 from cmake? |
@ipdemes : yes, the FindHDF5 from cmake wasn't behaving as expected. |
@cferenba I see, I have had some similar experience myself. Looks good to me. |
This modifies the configuration for legion to correctly find our hdf5 build (if requested).
@ktsai7 @ipdemes : please review. @opensdh : FYI.