Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homestead v15 - Ubuntu 22.04 - PHP 8.3 #1921

Merged
merged 2 commits into from
Jan 12, 2024
Merged

Homestead v15 - Ubuntu 22.04 - PHP 8.3 #1921

merged 2 commits into from
Jan 12, 2024

Conversation

svpernova09
Copy link
Contributor

Ubuntu 22.04
PHP 8.3 Default
Add Golang to base box
Remove Drush Launcher
Remove Drupal Launcher
Replace MailHog with Mailpit

svpernova09 and others added 2 commits January 11, 2024 21:07
Mailhog -> Mailpit
PHP Default 8.3
@svpernova09 svpernova09 merged commit 41555c3 into main Jan 12, 2024
8 checks passed
@svpernova09 svpernova09 deleted the 15x branch January 12, 2024 03:16
@browner12
Copy link
Contributor

Congrats Joe! Thanks as always for all the hard work you put into this awesome project!

@browner12
Copy link
Contributor

Surprised you built the Virtualbox version first, considering all the problems you seemed to have with it. Were there issues with the Parallels version, too, or is that guy on the way?

@svpernova09
Copy link
Contributor Author

Surprised you built the Virtualbox version first, considering all the problems you seemed to have with it. Were there issues with the Parallels version, too, or is that guy on the way?

I wanted to get the Virtualbox built and out as a test to see if I missed anything big. It's been a few days and so far so good. I'll get Parallels built and uploaded soon(tm)

@browner12
Copy link
Contributor

Gotcha, thanks for the response!

@svpernova09
Copy link
Contributor Author

Gotcha, thanks for the response!

Parallels box uploaded.

@browner12
Copy link
Contributor

So the recommendation previously was to be on the "release" branch when working in Homestead, which I see hasn't been updated with these changes. Are we changing how we do branching, or are you still considering this "pre-release"?

@svpernova09
Copy link
Contributor Author

So the recommendation previously was to be on the "release" branch when working in Homestead, which I see hasn't been updated with these changes. Are we changing how we do branching, or are you still considering this "pre-release"?

The box is ready for use, but you'd need to be on Homestead's main branch currently because I still haven't tagged a release. I've done my minimal testing but I'd love to hear another success before tagging. If you'd rather wait and not test drive that's fine too :D

@browner12
Copy link
Contributor

Thanks for the clarification. I'll test out the Parallels ARM version on my home MacBook tonight.

@browner12
Copy link
Contributor

I successfully got the new box running on my MacBook Pro tonight, with the ARM64 Parallels version. It even feels snappier than the old box!

Had some minimal issues, which I'll try to spell out here.

  • in my Homestead.yaml file, I had a custom override box key pointing to the laravel/homestead-arm box. Probably a remnant from the very old days when the ARM version was first being built, but I needed to remove that for it to work.

I'd say to avoid confusion it would be nice if we could remove the laravel/homestead-arm box at https://app.vagrantup.com/laravel, but I'm not sure if that's allowed. Ideally we'd remove the other random boxes ("mariadb" and "7") as well.

There is also the warning of the use of the deprecated apt-key, which I believe we also had in the old box. It would be nice if we could make these updates to remove those warnings, and I'd definitely be willing to help with that.

Otherwise, the box seems to behaving just like before.


There do appear to be some issues that carried over from the previous version, probably unrelated to the box, and more related to the provision scripts.

  • the "mysql" key is not a valid feature, and results in Invalid feature: mysql. This might just be an example file and documentation we need to change.
  • I am getting errors when setting the "web-driver" feature to true. It could possibly be related to the apt-key issues. Keeping this disabled allows the provision to continue.

I'll be on the LaraSlack tomorrow if you'd like to discuss any of these things in a more realtime setting.

Thanks!

@browner12
Copy link
Contributor

One possible issue found. On a site that I have both the cache_driver and session_driver set to "redis", I'm getting a "Class "Redis" not found" error. Trying to dig in why that might be happening, and will report back. I always get confused by the PHP Redis Extension vs Predis stuff, so I'll have to re-familiarize myself with it.

@svpernova09
Copy link
Contributor Author

in my Homestead.yaml file, I had a custom override box key pointing to the laravel/homestead-arm box. Probably a remnant from the very old days when the ARM version was first being built, but I needed to remove that for it to work.

Yes, part of this work has been to consolidate onto the laravel/homestead base box on app.vagrantup.com. Sorry, this wasn't more clear, docs should certainly be updated in this regard. Vagrant 2.4 is what brought architecture awareness and the big reason we have to require that minimum version despite some not-fun Virtualbox JavaScript bugs.

I'd say to avoid confusion it would be nice if we could remove the laravel/homestead-arm box at https://app.vagrantup.com/laravel, but I'm not sure if that's allowed. Ideally we'd remove the other random boxes ("mariadb" and "7") as well.

I need to review those and see if it's time to delete the boxes or at least remove the downloads.

@svpernova09
Copy link
Contributor Author

svpernova09 commented Jan 17, 2024

the "mysql" key is not a valid feature, and results in Invalid feature: mysql. This might just be an example file and documentation we need to change.

From my Homestead.yaml

folders:
    - map: /Users/halo/Code/fresh
      to: /home/vagrant/fresh

sites:
    - map: fresh.test
      to: /home/vagrant/fresh/public

databases:
    - fresh

features:
    - ohmyzsh: false
    - webdriver: false

services:
    - mysql: true

image

@svpernova09
Copy link
Contributor Author

I am getting errors when setting the "web-driver" feature to true. It could possibly be related to the apt-key issues. Keeping this disabled allows the provision to continue.

Confirmed the webdriver feature is broken. Needs to be updated to something ~

wget -q -O - https://dl.google.com/linux/linux_signing_key.pub | gpg --dearmour -o /usr/share/keyrings/chrome-keyring.gpg
echo "deb [arch=amd64 signed-by=/usr/share/keyrings/chrome-keyring.gpg] http://dl.google.com/linux/chrome/deb/ stable main" > /etc/apt/sources.list.d/google.list'

But we need a condition check for arch in the echo.

@browner12
Copy link
Contributor

browner12 commented Jan 17, 2024

Here is my php -m output for an old build vs a new build.

OLD

[PHP Modules]
bcmath
bz2
calendar
Core
ctype
curl
date
dba
dom
enchant
exif
FFI
fileinfo
filter
ftp
gd
gettext
gmp
hash
iconv
igbinary
imagick
imap
intl
json
ldap
libxml
mbstring
memcached
msgpack
mysqli
mysqlnd
odbc
openssl
pcntl
pcre
PDO
pdo_dblib
pdo_mysql
PDO_ODBC
pdo_pgsql
pdo_sqlite
pgsql
Phar
posix
pspell
random
readline
redis
Reflection
session
shmop
SimpleXML
snmp
soap
sockets
sodium
SPL
sqlite3
standard
sysvmsg
sysvsem
sysvshm
tidy
tokenizer
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zip
zlib

[Zend Modules]
Zend OPcache

NEW

[PHP Modules]
bcmath
bz2
calendar
Core
ctype
curl
date
dba
dom
enchant
exif
FFI
fileinfo
filter
ftp
gd
gettext
gmp
hash
iconv
imagick
imap
intl
json
ldap
libxml
mbstring
mysqli
mysqlnd
odbc
openssl
pcntl
pcre
PDO
pdo_dblib
pdo_mysql
PDO_ODBC
pdo_pgsql
pdo_sqlite
pgsql
Phar
posix
pspell
random
readline
Reflection
session
shmop
SimpleXML
snmp
soap
sockets
sodium
SPL
sqlite3
standard
sysvmsg
sysvsem
sysvshm
tidy
tokenizer
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zip
zlib

[Zend Modules]
Zend OPcache

The diff is the OLD has:

  • igbinary
  • memcached
  • msgpack
  • redis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants