Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] feat: add generics to eloquent Attribute cast #54361

Closed
wants to merge 1 commit into from

Conversation

calebdw
Copy link
Contributor

@calebdw calebdw commented Jan 26, 2025

Hello!

This PR adds generics to the Eloquent Attribute cast.

Thanks!

@taylorotwell
Copy link
Member

Hello, please resubmit with before and after screenshots of the incorrect behavior in your IDE before and correct behavior after.

@calebdw
Copy link
Contributor Author

calebdw commented Jan 27, 2025

@taylorotwell,

Larastan uses these generics to determine the readable (TGet) and writable (TSet) property types for the attributes. I was trying to move this stub into the framework

Best,

@calebdw calebdw deleted the attribute_generics branch January 27, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants