wip

Signed-off-by: Mior Muhammad Zaki <[email protected]>
laravel · Jan 5, 2024 · 1dd0e1b · 1dd0e1b
1 parent 93cf64a
commit 1dd0e1b
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/src/Concerns/ProvidesBrowser.php b/src/Concerns/ProvidesBrowser.php
@@ -6,6 +6,7 @@
 use Exception;
 use Illuminate\Support\Collection;
 use Laravel\Dusk\Browser;
+use PHPUnit\Framework\Attributes\AfterClass;
 use PHPUnit\Runner\Version;
 use ReflectionFunction;
 use Throwable;
@@ -29,10 +30,9 @@ trait ProvidesBrowser
     /**
      * Tear down the Dusk test case class.
      *
-     * @afterClass
-     *
      * @return void
      */
+    #[AfterClass]
     public static function tearDownDuskClass()
     {
         static::closeAll();

diff --git a/tests/Unit/OperatingSystemTest.php b/tests/Unit/OperatingSystemTest.php
@@ -3,6 +3,7 @@
 namespace Laravel\Dusk\Tests\Unit;
 
 use Laravel\Dusk\OperatingSystem;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 
 class OperatingSystemTest extends TestCase
@@ -41,9 +42,7 @@ public function test_it_cant_resolve_invalid_chrome_version_commands()
         OperatingSystem::chromeVersionCommands('window_os');
     }
 
-    /**
-     * @dataProvider resolveChromeDriverSlugDataProvider
-     */
+    #[DataProvider('resolveChromeDriverSlugDataProvider')]
     public function test_it_can_resolve_chromedriver_slug($version, $os, $expected)
     {
         $this->assertSame($expected, OperatingSystem::chromeDriverSlug($os, $version));

diff --git a/tests/Unit/ProvidesBrowserTest.php b/tests/Unit/ProvidesBrowserTest.php
@@ -4,6 +4,7 @@
 
 use Laravel\Dusk\Concerns\ProvidesBrowser;
 use Mockery as m;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use stdClass;
 
@@ -16,9 +17,7 @@ protected function tearDown(): void
         m::close();
     }
 
-    /**
-     * @dataProvider testData
-     */
+    #[DataProvider('testData')]
     public function test_capture_failures_for()
     {
         $browser = m::mock(stdClass::class);
@@ -30,9 +29,7 @@ public function test_capture_failures_for()
         $this->captureFailuresFor($browsers);
     }
 
-    /**
-     * @dataProvider testData
-     */
+    #[DataProvider('testData')]
     public function test_store_console_logs_for()
     {
         $browser = m::mock(stdClass::class);