Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard function to messages #183

Merged
merged 9 commits into from
Oct 24, 2023

Conversation

abbasudo
Copy link
Contributor

normal keyboard function added to messages

TelegramMessage::create()
            ->to($notifiable->telegram_user_id)
            ->content('Hello there!')
            ->keyboard('Button 1')
            ->keyboard('Button 2');

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Merging #183 (5102df4) into master (5c9fc73) will increase coverage by 1.75%.
The diff coverage is 88.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
+ Coverage     51.53%   53.28%   +1.75%     
- Complexity      110      112       +2     
============================================
  Files            12       12              
  Lines           293      304      +11     
============================================
+ Hits            151      162      +11     
  Misses          142      142              
Files Coverage Δ
src/Traits/HasSharedLogic.php 95.55% <100.00%> (+1.43%) ⬆️
src/TelegramFile.php 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@irazasyed
Copy link
Member

irazasyed commented Oct 19, 2023

Please add example screenshot previews and update the docs too.

Please don't forget to add relevant tests too.

@abbasudo
Copy link
Contributor Author

@irazasyed thanks for reviewing the code. I have added 3 tests and a screenshot to the docs. please tell me if there are any other changes that I have to make.

@abbasudo abbasudo requested a review from irazasyed October 19, 2023 23:13
@irazasyed irazasyed merged commit 7134469 into laravel-notification-channels:master Oct 24, 2023
3 checks passed
@irazasyed
Copy link
Member

Merged. Thanks for the PR and for all the requested changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants