[feat] add compatibility with laravel 11 #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aryala7 thank you, this is awesome! I'll check the PR tomorrow. |
|
@Sairahcaz Ich freue mich sehr, dass du meine PR interessant findest. ✌🏻 |
|
Hi @aryala7, the tests are failing. The thing ist that doctrine/dbal has been removed from Laravel 11. So you can't just update composer to make this work. Feel free to create a new PR which removes all doctrine dependencies from the package. |
|
@Sairahcaz ok i will open a new pull request |
|
The issue in your PR is because of carbon missing for the test matrix. However, some more work needs to be done for 11, as : |
|
Hi @mathieutu Yes I have already fixed the versioning section and going to create another pull request today |
@aryala7 Did you take the time to work on it as planned? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds Laravel 11 compatibility