Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor lantern_extras SQL functions #351

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Nov 1, 2024

  • Remove cohere_embedding, clip_text, clip_image functions
  • Add llm_embedding function
  • Refactor arguments for llm_completion function
  • Refactor arguments for add_embedding_job function
  • Refactor arguments for add_completion_job function
  • Remove GUC lantern_extras.openai_azure_api_token, lantern_extras.cohere_token and use lantern_extras.llm_token instead

- Remove `cohere_embedding`, `clip_text`, `clip_image` functions
- Add `llm_embedding` function
- Refactor arguments for `llm_completion` function
- Refactor arguments for `add_embedding_job` function
- Refactor arguments for `add_completion_job` function
- Remove GUC `lantern_extras.openai_azure_api_token`, `lantern_extras.cohere_token` and use `lantern_extras.llm_token` instead
@var77 var77 requested a review from Ngalstyan4 November 1, 2024 13:24
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage

8 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 1.56250% with 189 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lantern_extras/src/embeddings.rs 0.00% 100 Missing ⚠️
lantern_extras/src/daemon.rs 0.00% 85 Missing ⚠️
lantern_cli/src/embeddings/core/openai_runtime.rs 50.00% 3 Missing ⚠️
lantern_extras/src/lib.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@var77 var77 merged commit 3343ed0 into main Nov 4, 2024
55 of 56 checks passed
@var77 var77 deleted the varik/refactor-lantern-extras-functions branch November 4, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants