WAL/blockmaps: continue blockmaps initialization after failure #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContinueBlockMapGroupInitialization() description has all the details about how it's done and how different kinds of failures are handled.
…endBufferedRelTo() for PostgreSQL < 16
…erPage.blockmap_groups[]
medvied
added a commit
to medvied/lantern
that referenced
this pull request
Oct 25, 2023
An issue with PG_VERSION_NUM definition for PostgreSQL < 15 has been revealed by lanterndata#211: PG_VERSION_NUM is defined for PostgreSQL 16. Inside the build environment for PostgreSQL 15 it looks like the following: ``` /usr/include/postgresql/pg_config.h:#define PG_VERSION_NUM 160000 /usr/include/postgresql/15/server/pg_config.h:#define PG_VERSION_NUM 150004 /usr/include/postgresql/15/server/fmgr.h: PG_VERSION_NUM / 100, \ ``` And the build command for, for example, `src/hnsw/external_index.c` looks like this: ``` /usr/bin/cc -DLANTERN_USE_USEARCH -Dlantern_EXPORTS -I/tmp/lantern/./third_party/usearch/c -isystem /usr/include/postgresql -isystem /usr/include/postgresql/15/server -isystem /tmp/lantern/src -isystem /tmp/lantern -Wall -Wextra -Wno-conversion -Wno-unknown-pragmas -fPIC -MD -MT CMakeFiles/lantern.dir/src/hnsw/external_index.c.o -MF CMakeFiles/lantern.dir/src/hnsw/external_index.c.o.d -o CMakeFiles/lantern.dir/src/hnsw/external_index.c.o -c /tmp/lantern/src/hnsw/external_index.c ``` We see ``` -isystem /usr/include/postgresql ``` followed by ``` -isystem /usr/include/postgresql/15/server ``` which means that `PG_VERSION_NUM` would be defined as `160000`. We see that the first file is from `libpq-dev`, which is not being used by Lantern. ``` libpq-dev: /usr/include/postgresql/pg_config.h postgresql-server-dev-15: /usr/include/postgresql/15/server/pg_config.h ``` This patch changes the order of directories for header search to use the server dir first, so the right `PG_VERSION_NUM` would be defined for builds for the older PostgreSQL versions.
medvied
added a commit
to medvied/lantern
that referenced
this pull request
Oct 25, 2023
An issue with PG_VERSION_NUM definition for PostgreSQL < 15 has been revealed by lanterndata#211: PG_VERSION_NUM is defined for PostgreSQL 16. Inside the build environment for PostgreSQL 15 it looks like the following: ``` > grep -R PG_VERSION_NUM /usr/include/ /usr/include/postgresql/pg_config.h:#define PG_VERSION_NUM 160000 /usr/include/postgresql/15/server/pg_config.h:#define PG_VERSION_NUM 150004 /usr/include/postgresql/15/server/fmgr.h: PG_VERSION_NUM / 100, \ ``` And the build command for, for example, `src/hnsw/external_index.c` looks like this: ``` /usr/bin/cc -DLANTERN_USE_USEARCH -Dlantern_EXPORTS -I/tmp/lantern/./third_party/usearch/c -isystem /usr/include/postgresql -isystem /usr/include/postgresql/15/server -isystem /tmp/lantern/src -isystem /tmp/lantern -Wall -Wextra -Wno-conversion -Wno-unknown-pragmas -fPIC -MD -MT CMakeFiles/lantern.dir/src/hnsw/external_index.c.o -MF CMakeFiles/lantern.dir/src/hnsw/external_index.c.o.d -o CMakeFiles/lantern.dir/src/hnsw/external_index.c.o -c /tmp/lantern/src/hnsw/external_index.c ``` We see ``` -isystem /usr/include/postgresql ``` followed by ``` -isystem /usr/include/postgresql/15/server ``` which means that `PG_VERSION_NUM` would be defined as `160000`. We see that the first file is from `libpq-dev`, which is not being used by Lantern. ``` > dpkg -S /usr/include/postgresql/pg_config.h libpq-dev: /usr/include/postgresql/pg_config.h > dpkg -S /usr/include/postgresql/15/server/pg_config.h postgresql-server-dev-15: /usr/include/postgresql/15/server/pg_config.h ``` This patch changes the order of directories for header search to use the server dir first, so the right `PG_VERSION_NUM` would be defined for builds for the older PostgreSQL versions.
Ngalstyan4
pushed a commit
that referenced
this pull request
Oct 25, 2023
An issue with PG_VERSION_NUM definition for PostgreSQL < 15 has been revealed by #211: PG_VERSION_NUM is defined for PostgreSQL 16. Inside the build environment for PostgreSQL 15 it looks like the following: ``` > grep -R PG_VERSION_NUM /usr/include/ /usr/include/postgresql/pg_config.h:#define PG_VERSION_NUM 160000 /usr/include/postgresql/15/server/pg_config.h:#define PG_VERSION_NUM 150004 /usr/include/postgresql/15/server/fmgr.h: PG_VERSION_NUM / 100, \ ``` And the build command for, for example, `src/hnsw/external_index.c` looks like this: ``` /usr/bin/cc -DLANTERN_USE_USEARCH -Dlantern_EXPORTS -I/tmp/lantern/./third_party/usearch/c -isystem /usr/include/postgresql -isystem /usr/include/postgresql/15/server -isystem /tmp/lantern/src -isystem /tmp/lantern -Wall -Wextra -Wno-conversion -Wno-unknown-pragmas -fPIC -MD -MT CMakeFiles/lantern.dir/src/hnsw/external_index.c.o -MF CMakeFiles/lantern.dir/src/hnsw/external_index.c.o.d -o CMakeFiles/lantern.dir/src/hnsw/external_index.c.o -c /tmp/lantern/src/hnsw/external_index.c ``` We see ``` -isystem /usr/include/postgresql ``` followed by ``` -isystem /usr/include/postgresql/15/server ``` which means that `PG_VERSION_NUM` would be defined as `160000`. We see that the first file is from `libpq-dev`, which is not being used by Lantern. ``` > dpkg -S /usr/include/postgresql/pg_config.h libpq-dev: /usr/include/postgresql/pg_config.h > dpkg -S /usr/include/postgresql/15/server/pg_config.h postgresql-server-dev-15: /usr/include/postgresql/15/server/pg_config.h ``` This patch changes the order of directories for header search to use the server dir first, so the right `PG_VERSION_NUM` would be defined for builds for the older PostgreSQL versions.
This patch adds API to trigger execution of C code from SQL to test corner cases. `test/sql/hnsw_failure_point.sql` has an example of how to trigger a process crash using failure points and how to see that a space leak happens if a crash happens after a block is allocated, but before a record for the block is added to the index during blockmaps creation.
This reverts commit 821b41f.
|
Rebased and merged in PR 214 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContinueBlockMapGroupInitialization() description has all the details about how it's done and how different kinds of failures are handled.