Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew formula release #183

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Homebrew formula release #183

merged 3 commits into from
Sep 28, 2023

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Sep 26, 2023

Added release action to update homebrew formula version.
Added ability to specify pg_config from PG_CONFIG env variable on cmake/FindPostgreSQL.cmake, so we can be sure that homebrew formula will compile Lantern against the same postgres version it has found.

@var77 var77 requested a review from Ngalstyan4 September 26, 2023 16:17
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #183 (479b45a) into main (39b5b00) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #183   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files          17       17           
  Lines        1161     1161           
  Branches      245      245           
=======================================
  Hits          967      967           
  Misses         85       85           
  Partials      109      109           

@github-actions
Copy link

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.738 0.778 +5.42%
select bulk tps 214.972 239.951 +11.62%
select bulk latency (ms) 36.515 32.620 -10.67%
select bulk latency (stddev ms) 8.139 6.875 -15.53%
create latency (ms) 1497.447 1566.374 +4.60%
insert bulk tps 14.138 14.087 -0.37%
insert bulk latency (ms) 70.718 70.977 +0.37%
insert bulk latency (stddev ms) 3.203 2.302 -28.13%
disk usage (bytes) 6348800.000 6348800.000 -

@var77 var77 mentioned this pull request Sep 26, 2023
Copy link
Contributor

@Ngalstyan4 Ngalstyan4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@var77, Merge this once the brew tap is ready

@var77 var77 merged commit 5d9ffe0 into main Sep 28, 2023
@var77 var77 deleted the varik/homebrew-formula branch September 28, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants