Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify pg_config from env variables #182

Closed
wants to merge 1 commit into from

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Sep 26, 2023

This change will help us to specify the pg_config from env variable PG_CONFIG.
This is needed for homebrew formula, so we will make sure that we are compiling against the same version that we have found in homebrew.

@var77 var77 requested a review from Ngalstyan4 September 26, 2023 11:59
@github-actions
Copy link

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.738 0.774 +4.88%
select bulk tps 214.972 218.022 +1.42%
select bulk latency (ms) 36.515 34.106 -6.60%
select bulk latency (stddev ms) 8.139 14.026 +72.33%
create latency (ms) 1497.447 1603.106 +7.06%
insert bulk tps 14.138 13.407 -5.17%
insert bulk latency (ms) 70.718 74.575 +5.45%
insert bulk latency (stddev ms) 3.203 2.949 -7.93%
disk usage (bytes) 6348800.000 6348800.000 -

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #182 (d4fdaba) into main (39b5b00) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #182   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files          17       17           
  Lines        1161     1161           
  Branches      245      245           
=======================================
  Hits          967      967           
  Misses         85       85           
  Partials      109      109           

@var77 var77 closed this Sep 26, 2023
@var77 var77 deleted the varik/pg-config-from-env branch September 30, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant