Make check_symbols not accept dynamic c++ symbols #181
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our static usearch library still depended on the cpp runtime library libstdc++ dynamically.
This usually did not cause issues since postgres
commonly links libstdc++ dynamically so c++ symbols in our .so would be resolved dynamically, when loaded.
This did cause issues for when postgres was not linked with libstdc++. I do not know when exactly this happens but it seems this at least happens when building postgres from source under certain circumstances
This commit makes sure that we do not use libstdc++ symbols from postgres dynamic library dependency and actually enforce that all c++ symbols we require are in the sahred object we build