Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix operator classes for lantern_hnsw access method #180

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

var77
Copy link
Collaborator

@var77 var77 commented Sep 26, 2023

Currently there's an issue that when pgvector exists and we create lantern_hnsw access method, operator classes are not being registered on that access method, but on hnsw, so we are unable to create Lantern hnsw index.
This change will make sure to create operator classes on right access method. I have created a function _create_ldb_operator_classes to avoid code duplication.

@var77 var77 requested review from Ngalstyan4 and dqii September 26, 2023 07:53
@github-actions
Copy link

github-actions bot commented Sep 26, 2023

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.776 0.774 -0.26%
select bulk tps 234.291 223.460 -4.62%
select bulk latency (ms) 31.739 34.754 +9.50%
select bulk latency (stddev ms) 11.093 8.409 -24.20%
create latency (ms) 1447.931 1469.768 +1.51%
insert bulk tps 14.880 14.516 -2.45%
insert bulk latency (ms) 67.187 68.877 +2.52%
insert bulk latency (stddev ms) 2.692 2.561 -4.87%
disk usage (bytes) 6348800.000 6348800.000 -

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #180 (3b54578) into main (4c80eca) will increase coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
+ Coverage   82.93%   83.09%   +0.16%     
==========================================
  Files          17       17              
  Lines        1201     1201              
  Branches      256      256              
==========================================
+ Hits          996      998       +2     
+ Misses         87       81       -6     
- Partials      118      122       +4     

see 2 files with indirect coverage changes

@var77 var77 force-pushed the varik/fix-lantern-hnsw-sql branch from 7a16ff9 to a0473e3 Compare September 26, 2023 18:20
@var77 var77 force-pushed the varik/fix-lantern-hnsw-sql branch from a0473e3 to 3b54578 Compare September 30, 2023 13:09
@var77 var77 merged commit 29af187 into main Sep 30, 2023
27 checks passed
@var77 var77 deleted the varik/fix-lantern-hnsw-sql branch September 30, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants