Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support expression-based index operator checks #179

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Conversation

dqii
Copy link
Contributor

@dqii dqii commented Sep 25, 2023

No description provided.

@Ngalstyan4
Copy link
Contributor

@var77 , it seems code coverage does not run even when just benchmarking fails.
Can we make it so that code coverage runs as long as build succeeds and tests pass?

@var77
Copy link
Collaborator

var77 commented Sep 26, 2023

@Ngalstyan4 I think there's an issue with codecov not running the checks after we have changed the repo name. Can you try to reinstall the Codecov app and update codecov token in action secrets? Maybe that will fix the issue

@dqii dqii marked this pull request as ready for review September 26, 2023 16:48
@dqii dqii closed this Sep 26, 2023
@dqii dqii reopened this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #179 (6f97a02) into main (40dcf10) will decrease coverage by 1.06%.
Report is 7 commits behind head on main.
The diff coverage is 63.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #179      +/-   ##
==========================================
- Coverage   84.12%   83.06%   -1.06%     
==========================================
  Files          18       17       -1     
  Lines        1165     1175      +10     
  Branches      245      251       +6     
==========================================
- Hits          980      976       -4     
  Misses         85       85              
- Partials      100      114      +14     
Files Coverage Δ
src/hooks/executor_start.c 89.47% <0.00%> (ø)
src/hooks/post_parse.c 89.87% <66.66%> (-5.52%) ⬇️

... and 10 files with indirect coverage changes

@github-actions
Copy link

Benchmarks

metric old new pct change
recall (after create) 0.740 0.740 -
recall (after insert) 0.748 0.750 +0.27%
select bulk tps 195.864 225.659 +15.21%
select bulk latency (ms) 38.565 34.764 -9.86%
select bulk latency (stddev ms) 12.361 7.369 -40.39%
create latency (ms) 1518.336 1464.022 -3.58%
insert bulk tps 12.235 14.702 +20.16%
insert bulk latency (ms) 81.713 68.001 -16.78%
insert bulk latency (stddev ms) 3.270 2.241 -31.47%
disk usage (bytes) 6348800.000 6348800.000 -

@dqii dqii merged commit e87563a into main Sep 26, 2023
@dqii dqii deleted the @di/add-create-expr-test branch September 26, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants