Reindex external indexes properly on updates #282

lanterndata · Feb 8, 2024 · 192a4f2 · 192a4f2
1 parent 5cea216
commit 192a4f2
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/sql/lantern.sql b/sql/lantern.sql
@@ -185,11 +185,15 @@ RETURNS VOID AS $$
 DECLARE
     r RECORD;
 BEGIN
-    FOR r IN SELECT indexname FROM pg_indexes
+    FOR r IN SELECT indexname, indexdef FROM pg_indexes
             WHERE indexdef ILIKE '%USING hnsw%' OR indexdef ILIKE '%USING lantern_hnsw%'
     LOOP
         RAISE NOTICE 'Reindexing index: %', r.indexname;
-        EXECUTE 'REINDEX INDEX ' || quote_ident(r.indexname) || ';';
+        IF POSITION('_experimental_index_path' in r.indexdef) > 0 THEN
+          PERFORM lantern_reindex_external_index(r.indexname::regclass);
+        ELSE
+          EXECUTE 'REINDEX INDEX ' || quote_ident(r.indexname) || ';';
+        END IF;
         RAISE NOTICE 'Reindexed index: %', r.indexname;
     END LOOP;
 END $$ LANGUAGE plpgsql VOLATILE;
diff --git a/sql/updates/0.1.0--0.1.1.sql b/sql/updates/0.1.0--0.1.1.sql
@@ -0,0 +1,20 @@
+-- Database updates
+-- Must be run in update scripts every time index storage format changes and a finer-grained update
+-- method is not shipped for the format change
+CREATE OR REPLACE FUNCTION _lantern_internal.reindex_lantern_indexes()
+RETURNS VOID AS $$
+DECLARE
+    r RECORD;
+BEGIN
+    FOR r IN SELECT indexname, indexdef FROM pg_indexes
+            WHERE indexdef ILIKE '%USING hnsw%' OR indexdef ILIKE '%USING lantern_hnsw%'
+    LOOP
+        RAISE NOTICE 'Reindexing index: %', r.indexname;
+        IF POSITION('_experimental_index_path' in r.indexdef) > 0 THEN
+          PERFORM lantern_reindex_external_index(r.indexname::regclass);
+        ELSE
+          EXECUTE 'REINDEX INDEX ' || quote_ident(r.indexname) || ';';
+        END IF;
+        RAISE NOTICE 'Reindexed index: %', r.indexname;
+    END LOOP;
+END $$ LANGUAGE plpgsql VOLATILE;