-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update submodules, API changes, tracer swarm packs, formatting CI #225
Open
AstroBarker
wants to merge
24
commits into
main
Choose a base branch
from
blb/update_parthenon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+464
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AstroBarker
changed the title
Update submodules, API changes, tracer swarm packs
Update submodules, API changes, tracer swarm packs, formatting CI
Jan 6, 2025
AstroBarker
changed the title
Update submodules, API changes, tracer swarm packs, formatting CI
WIP: Update submodules, API changes, tracer swarm packs, formatting CI
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Far overdue, this PR updates
parthenon
,singularity-eos
, andsingularity-opac
and makes necessary changes to work with their updated versions.Updates to MHD (API changes for packing)
Overhauls to swarm API
MeshData
The advection problem's tracers were refactored due to a bug on multiple blocks
Some updates to BCs, probably more simplification can be done.
The fast logs of
singularity-eos
are default disabled.Updates neutrino mean opacity API
Tracers:
MeshData
instead ofMeshBlockData
SWARM_VARIABLES
now, so access with e.g.,tv::rho()
,tv::rho::name()
e.g., (fornamespace tv = tracer_variables;
to enable type based packing.Also, the github
ubuntu-latest
changed andclang-format-12
was no longer available. I have moved us to installingclang-format
withpip
, pinned at version12.0.1
. Which was not compatible with ubuntu's v12...Weirdness seems to have crept in to the regression testing. Some tests, despite producing an identical gold file (when ran with
--upgold
) failed tests due to how hdf5 was loaded. Unsure what caused this change, but a fix was implemented.