Merge homologouscollapse changes into main #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mari2895 can you run the formatting script so the tests pass? |
Yurlungur
approved these changes
Nov 8, 2023
| @@ -165,7 +165,15 @@ TaskStatus CoolingFunctionCalculateFourForce(MeshBlockData<Real> *rc, const doub | |||
| }); | |||
|
|
|||
| // Light Bulb with Liebendorfer model | |||
| const bool is_monopole_cart = | |||
There was a problem hiding this comment.
@carlnotsagan the substantial change is here, but it has to do with spherical vs cartesian coords
|
@Yurlungur did we not merge this? I think we don't need this anymore. Can you please make sure that is the case and if so I'll close it. |
|
It looks like we implemented an alternative solution which is currently in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist
scripts/bash/format.sh.