Inconsistent behavior between CPU and GPU for liebendorf deleptonization and cooling #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yurlungur
reviewed
Nov 7, 2023
carlnotsagan
changed the title
|
@carlnotsagan do you encounter the same issue when running lightbulb with @mari2895 's CCSN problem initialization? If not maybe it has to do with changes in the SASW branch? Can you share the code for SASW in a PR? |
carlnotsagan
changed the title
carlnotsagan
changed the title
|
thanks for merging main, should be all good now |
|
Looks like tests are still failing? |
mari2895
approved these changes
Dec 13, 2023
|
looking into the fails. something to do with a reference to pmb |
mari2895
reviewed
Dec 13, 2023
src/radiation/cooling_function.cpp
Outdated
| @@ -39,7 +39,8 @@ TaskStatus LightBulbCalcTau(MeshBlockData<Real> *rc) { | |||
| IndexRange jb = rc->GetBoundsJ(IndexDomain::interior); | |||
| IndexRange kb = rc->GetBoundsK(IndexDomain::interior); | |||
|
|
|||
| auto &unit_conv = params.Get<phoebus::UnitConversions>("unit_conv"); | |||
There was a problem hiding this comment.
@Yurlungur should not auto &unit_conv = params.Get<phoebus::UnitConversions>("unit_conv"); be working?
mari2895
reviewed
Dec 13, 2023
src/radiation/cooling_function.cpp
Outdated
Comment on lines
193
to
201
| // Code to CGS | ||
| const Real density_conversion_factor = unit_conv.GetMassDensityCodeToCGS(); | ||
| const Real temperature_conversion_factor = unit_conv.GetTemperatureCodeToCGS(); | ||
| const Real length_conversion_factor = unit_conv.GetLengthCodeToCGS(); | ||
|
|
||
| // CGS to code | ||
| const Real energy_conversion_factor = unit_conv.GetEnergyCGSToCode(); | ||
| const Real mass_conversion_factor = unit_conv.GetMassCGSToCode(); | ||
| const Real time_conversion_factor = unit_conv.GetTimeCGSToCode(); |
There was a problem hiding this comment.
These lines probably don't need to be here, because the same definitions are above in the same function.
added 2 commits
December 13, 2023 12:42
…to fix_typo_cooling
Yurlungur
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
when using
cooling_functionwith SASW/homologous problem. returns error::0: : block: [3,0,0], thread: [0,0,0] AssertionView bounds error of view p.densityfailed.after first step
this backtraces to:
the cooling function
Host function was being called from device function leading to issues on GPU.
Steps Taken: