[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

marcoagpinto · 2024-09-12T06:59:47Z

I have added an AP and fixed/improved two others.

Summary by CodeRabbit

New Features
- Introduced a new antipattern for the phrase "para tal" to improve grammar detection in Portuguese.
Improvements
- Enhanced accuracy of grammar checking by normalizing postag patterns across multiple tokens.

coderabbitai · 2024-09-12T07:00:06Z

Walkthrough

The pull request introduces modifications to the Portuguese language module of LanguageTool, specifically in the grammar.xml file. A new antipattern targeting the phrase "para tal" has been added, along with adjustments to existing antipatterns that normalize postag patterns for improved accuracy. These changes enhance the grammar checking capabilities of the module by refining the detection of specific phrases and ensuring correct postag formatting.

Changes

File Path	Change Summary
languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml	Added a new antipattern for "para tal" and modified postag patterns from `(SPS00)?:` to `(SPS00:)?`.

Possibly related PRs

[pt-PT] Added APs to rule ID:VERBO_HIFENIZADOR_VERBOS_2 #10867: This PR adds new antipatterns in the grammar.xml file for the Portuguese language, similar to the main PR's addition of an antipattern targeting the phrase "para tal."
[pt] Improved the disambiguation.xml #10868: This PR focuses on the disambiguation.xml file, involving grammar rules for the Portuguese language, which may relate to the overall grammar checking improvements in the main PR.
[pt] Fixed FPs in rule ID:OS_DOIS_AS_DUAS_AMBOS_AMBAS #10869: This PR modifies the style.xml file, related to grammar rules, which may impact how certain phrases are processed, aligning with the main PR's goal of refining grammar checking capabilities.

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 0354faf and e0e4116.

Files selected for processing (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)

Files skipped from review as they are similar to previous changes (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 0

Outside diff range and nitpick comments (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1)

Line range hint 1-1: Code changes are missing. Please provide the annotated code for review.

The annotated code section is empty, indicating that the code changes have not been provided. Without the code changes, it is not possible to perform a detailed review of the file.

Please update the pull request with the annotated code, including the line numbers and ~ signs to indicate the added or modified lines. This will allow me to generate accurate review comments on each changed code segment.

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 70f8f5f and 0354faf.

Files selected for processing (1)

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml (1 hunks)

susanaboatto · 2024-09-12T09:48:24Z

languagetool-language-modules/pt/src/main/resources/org/languagetool/rules/pt/grammar.xml

+                <token>tal</token>
+                <token postag='(SPS00:)?[DP]...[PN].+|VM...P.+' postag_regexp='yes'/>
+                <token postag="AQ..[PN].+|N..[PN].+|Z0.[PN].+|(SPS00:)?[DP]...[PN].+|VM...P.+" postag_regexp="yes"/>
+                <example>Quero para tal esses dois telemóveis.</example>


Could also work with "para tanto"

@susanaboatto

Done!

marcoagpinto · 2024-09-16T15:17:41Z

@susanaboatto

Any feedback on this one?

Thanks!

marcoagpinto · 2024-09-21T03:10:45Z

Heya, @p-goulart and @susanaboatto

LanguageTool entered feature freeze today, could one of you approve these changes before the official release?

Thanks!

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS

0354faf

marcoagpinto added the Portuguese label Sep 12, 2024

marcoagpinto requested review from p-goulart and susanaboatto September 12, 2024 06:59

coderabbitai bot reviewed Sep 12, 2024

View reviewed changes

susanaboatto reviewed Sep 12, 2024

View reviewed changes

[pt] Added "tanto" to last rule

e0e4116

marcoagpinto requested a review from susanaboatto September 12, 2024 09:57

susanaboatto approved these changes Sep 23, 2024

View reviewed changes

marcoagpinto merged commit 993a742 into master Sep 23, 2024
5 checks passed

marcoagpinto deleted the lt_marcoagpinto_20240912_0758 branch September 23, 2024 12:32

This was referenced Sep 29, 2024

[pt] Added rule ID:PARA_NADA_DESNECESSARIAMENTE #10904

Merged

[pt] Added rule ID:DEMASIADO_INVARIAVEL #10905

Merged

[pt] Added words to added.txt and spelling.txt #10917

Merged

coderabbitai bot mentioned this pull request Oct 6, 2024

[pt] Added APs to rule ID:CONCORDANCIA_SER_GENERO #10919

Merged

coderabbitai bot mentioned this pull request Nov 5, 2024

Jdk19 regexp fix #10972

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

marcoagpinto commented Sep 12, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 12, 2024 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

coderabbitai bot left a comment

susanaboatto Sep 12, 2024

marcoagpinto Sep 12, 2024

marcoagpinto commented Sep 16, 2024

marcoagpinto commented Sep 21, 2024

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

[pt] Added/improved APs in rule ID:GENERAL_NUMBER_AGREEMENT_ERRORS #10872

Conversation

marcoagpinto commented Sep 12, 2024 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Sep 12, 2024 • edited Loading

Walkthrough

Changes

Possibly related PRs

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

coderabbitai bot left a comment

Choose a reason for hiding this comment

susanaboatto Sep 12, 2024

Choose a reason for hiding this comment

marcoagpinto Sep 12, 2024

Choose a reason for hiding this comment

marcoagpinto commented Sep 16, 2024

marcoagpinto commented Sep 21, 2024

marcoagpinto commented Sep 12, 2024 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Sep 12, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)