Unify plugin endpoint configuration for api and worker: An alternative solution to PR #13214 #13239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify plugin endpoint configuration for
api
andworker
by adoptingPLUGIN_DAEMON_URL
/PLUGIN_DAEMON_KEY
and removingPLUGIN_API_URL
/PLUGIN_API_KEY
to avoid confusion.This is an alternative solution to #13214, which does things the other way around.
Fixes #13113
Summary
PR #13055 introduces
PLUGIN_API_URL
andPLUGIN_API_KEY
indocker-compose.yaml
, which coexists with the originalPLUGIN_DAEMON_URL
andPLUGIN_DAEMON_KEY
(the ones that actually take effect) and caused confusions that ends up inInternalServerError
(#12664). This PR and the alternative solution #13214 aims to unify these two settings.Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods