Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding list of Data output to Parse Data #4598

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

mieslep
Copy link
Contributor

@mieslep mieslep commented Nov 14, 2024

This pull request includes several changes to the ParseDataComponent class and related functions to enhance data processing capabilities. The most significant changes include adding new imports, updating input and output configurations, and modifying the data_to_text function to support more flexible data formatting.

Enhancements to data processing:

Updates to ParseDataComponent class:

Improvements to data_to_text function:

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Nov 14, 2024
Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #4598 will degrade performances by 20.26%

Comparing mieslep:phil/parse-data (559a32f) with main (7c04865)

Summary

⚡ 1 improvements
❌ 2 regressions
✅ 12 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main mieslep:phil/parse-data Change
test_invalid_run_with_input_type_chat 16.4 ms 13.8 ms +18.09%
test_successful_run_with_input_type_any 207.5 ms 235.8 ms -11.99%
test_successful_run_with_input_type_text 163.7 ms 205.4 ms -20.26%

@ogabrielluiz ogabrielluiz changed the title adding list of Data output to Parse Data feat: adding list of Data output to Parse Data Nov 14, 2024
@github-actions github-actions bot added the enhancement New feature or request label Nov 14, 2024
@mieslep
Copy link
Contributor Author

mieslep commented Nov 14, 2024

Will modify to keep signature of data_to_text as -> str only.

@mieslep
Copy link
Contributor Author

mieslep commented Nov 15, 2024

@ogabrielluiz this should now be gtg from my perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant