Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ollama): Export OllamaEmbeddingsParams interface #7574

Merged
merged 1 commit into from
Jan 25, 2025
Merged

chore(ollama): Export OllamaEmbeddingsParams interface #7574

merged 1 commit into from
Jan 25, 2025

Conversation

gurisko
Copy link
Contributor

@gurisko gurisko commented Jan 23, 2025

We are already exporting ChatOllamaInput in @langchain/ollama. It would be great to also export OllamaEmbeddingsParams for embeddings instance.

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jan 23, 2025 1:20pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ⬜️ Ignored (Inspect) Jan 23, 2025 1:20pm

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels Jan 23, 2025
jacoblee93
jacoblee93 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@jacoblee93 jacoblee93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, thank you!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Jan 24, 2025
@jacoblee93 jacoblee93 merged commit 86fa0d5 into langchain-ai:main Jan 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacoblee93 jacoblee93 jacoblee93 approved these changes

Assignees
No one assigned
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gurisko @jacoblee93