weaviate[minor]: Add Document className as metadata #7486
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
dosubot
bot
added
size:XS
jacoblee93
reviewed
Jan 9, 2025
| metadata: rest, | ||
| metadata: { | ||
| ...rest, | ||
| className: this.indexName |
There was a problem hiding this comment.
Should we just call it indexName instead of className?
There was a problem hiding this comment.
We could but the idea is to export the className metadata field from weaviate. Since we are exporting this field in the Document interface metadata field, I would think is even safer to use className to avoid any field name collision.
PD: Thanks for the fast feedback!
There was a problem hiding this comment.
In their docs I see:
https://weaviate.io/developers/weaviate/manage-data/collections
Newer Weaviate documentation discuses "collections." Older Weaviate documentation refers to "classes" instead. Expect to see both terms throughout the documentation.
Maybe collectionName is more appropriate?
There was a problem hiding this comment.
yeah, that makes sense. I will push an update, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
classNameas part of Document metadata.Why
EnsembleRetriever, we don't know where the docs are coming from.