Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oraclevs integration #29723

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

skmishraoracle
Copy link
Contributor

Thank you for contributing to LangChain!

  • PR title: "package: description"

    • Where "package" is whichever of langchain, community, core, etc. is being modified. Use "docs: ..." for purely docs changes, "infra: ..." for CI changes.
    • Example: "community: add foobar LLM"
      community: langchain_community/vectorstore/oraclevs.py
  • PR message: Delete this entire checklist and replace with

    • Description: Refactored code to allow a connection or a connection pool.
    • Issue: Normally an idel connection is terminated by the server side listener at timeout. A user thus has to re-instantiate the vector store. The timeout in case of connection is not configurable. The solution is to use a connection pool where a user can specify a user defined timeout and the connections are managed by the pool.
    • Dependencies: None
    • Twitter handle:
  • Add tests and docs: This is not a new integration. A user can pass either a connection or a connection pool. The determination of what is passed is made at run time. Everything should work as before.

  • Lint and test: Already done.

Additional guidelines:

  • Make sure optional dependencies are imported within a function.
  • Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests.
  • Most PRs should not touch more than one package.
  • Changes should be backwards compatible.
  • If you are adding something to community, do not re-import it in langchain.

If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Feb 11, 2025
Copy link

vercel bot commented Feb 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Visit Preview Feb 11, 2025 8:30am

@dosubot dosubot bot added community Related to langchain-community Ɑ: vector store Related to vector store module labels Feb 11, 2025
@skmishraoracle
Copy link
Contributor Author

@baskaryan, @efriis, @rohanaggarwal7997 - As per our last interaction I have split my old transaction into two. This transaction offers support for the database connection pool. In doing so, I have renamed the variable connection to client and set its datatype to Any. This has resulted in the refactoring of the code. It is not complicated, but occurs everywhere connection was used. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Related to langchain-community size:L This PR changes 100-499 lines, ignoring generated files. Ɑ: vector store Related to vector store module
Projects
Status: Triage
Development

Successfully merging this pull request may close these issues.

2 participants