-
Notifications
You must be signed in to change notification settings - Fork 16.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oraclevs integration #29723
base: master
Are you sure you want to change the base?
Oraclevs integration #29723
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
@baskaryan, @efriis, @rohanaggarwal7997 - As per our last interaction I have split my old transaction into two. This transaction offers support for the database connection pool. In doing so, I have renamed the variable connection to client and set its datatype to Any. This has resulted in the refactoring of the code. It is not complicated, but occurs everywhere connection was used. Please review. |
Thank you for contributing to LangChain!
PR title: "package: description"
community: langchain_community/vectorstore/oraclevs.py
PR message: Delete this entire checklist and replace with
Add tests and docs: This is not a new integration. A user can pass either a connection or a connection pool. The determination of what is passed is made at run time. Everything should work as before.
Lint and test: Already done.
Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.