Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mariadb plugin #62

Merged

Conversation

uberhacker
Copy link
Contributor

@uberhacker uberhacker commented May 18, 2024

Fixes #60.
Fixes #57.

Bare minimum self-checks

What do you think of a person who only does the bare minimum?

  • I've updated this PR with the latest code from main
  • I've done a cursory QA pass of my code locally
  • I've ensured all automated status check and tests pass
  • I've connected this PR to an issue

Pieces of flare

  • I've written a unit or functional test for my code
  • I've updated relevant documentation it my code changes it
  • I've updated this repo's README if my code changes it
  • I've updated this repo's CHANGELOG with my change unless its a trivial change (like updating a typo in the docs)

Finally

If you have any issues or need help please join the #contributors channel in the Lando slack and someone will gladly help you out!

You can also check out the coder guide.

Copy link

netlify bot commented May 18, 2024

Deploy Preview for lando-laravel ready!

Name Link
🔨 Latest commit 8c490ad
🔍 Latest deploy log https://app.netlify.com/sites/lando-laravel/deploys/66541b099c1a1f00085b5091
😎 Deploy Preview https://deploy-preview-62--lando-laravel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 16 from production)
Accessibility: 96 (no change from production)
Best Practices: 100 (no change from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@reynoldsalec reynoldsalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add the laravel-mariadb test to the .github/workflows/pr-laravel-tests.yml file: https://github.com/lando/laravel/blob/main/.github/workflows/pr-laravel-tests.yml#L20

Note that you'll need to do that in all plugins where you're adding a new test.

@uberhacker uberhacker force-pushed the 51-Update-MariaDB-Across-All-Recipes branch from 6c6a648 to 4f296d3 Compare May 20, 2024 22:30
reynoldsalec
reynoldsalec previously approved these changes May 21, 2024
reynoldsalec
reynoldsalec previously approved these changes May 21, 2024
@uberhacker uberhacker force-pushed the 51-Update-MariaDB-Across-All-Recipes branch from 1562741 to 8c490ad Compare May 27, 2024 05:32
@reynoldsalec reynoldsalec merged commit 5091fc5 into lando:main May 27, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants