-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compose): Fix compose file path resolution as it is copied into the lando config directory #88
base: main
Are you sure you want to change the base?
Conversation
👷 Deploy request for lando-core pending review.Visit the deploys page to approve it
|
@florianPat thanks for taking a swing at this, looks interesting! Note that I just got the tests are running with this repo's secrets, so you can use those to develop against if you're still interested in working on this. Thanks again! |
e885fe0
to
9d594c4
Compare
Hey @reynoldsalec, Thanks in advance, |
652f88b
to
dbfde80
Compare
9bb5b70
to
6da7cd2
Compare
Hey @reynoldsalec, Thanks in advance, |
3c98137
to
d139490
Compare
9e086a5
to
990c4ec
Compare
990c4ec
to
6503ba7
Compare
Looks very cool. That would be helpful for my projects... |
1a74413
to
a94ba53
Compare
24f2314
to
090837d
Compare
2402b67
to
f25c2df
Compare
lando directory and be able to set app mount user and use docker compose v2 seperator and just share the .ssh directory for no docker desktop warnings Refs: lando/lando#3373
…ssion setup is finished Refs: lando/lando#3373
… containers on exec if the full compose stack did not start yet Refs: lando/lando#3373
…ers on exec if they were not started yet Refs: lando/lando#3373
…fore do not copy the files over
So one does not have to rebuild if a docker compose up lasts, for example for adding env vars
d86947d
to
f2d4c57
Compare
Hey there,
to work with lando as a drop in replacement for docker-compose and the "compose" config feature, the paths to env_files, volume definitions and build contexts need to be resolved correctly. As the docker compose files get copied into the lando compose config directory, these paths change from the compose project directory. This pull request aims to resolve issue 3373, which explains this issue.
It creates a new docker compose routing method to use the docker compose config command to generate the config relative to the target directory (lando-dir/compose/project-name), so that every docker compose stack just works with lando (for an example, see this commit.
Moreover, the app_mount can be disabled globally for every service due to a top level app_mount config, and one does not have to disable it for every service.
I would love some feedback on this feature.
Thanks in advance,
Flo