Issue 3373 #268
Open
Issue 3373 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lando-core ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
florianPat
force-pushed
the
issue-3373
branch
from
7fc905b
to
c62f483
Compare
lando directory and be able to set app mount user
…esktop warnings about the home directory volume
…ful per default ;)
…essly with docker compose stacks
…rt for version 3 containers and before tooling to make sure the permission setup is finished Fix wait-for-user.sh to also wait for the group Refs: lando/lando#3373
…fore do not copy the files over
…pp for v3 services
florianPat
force-pushed
the
issue-3373
branch
from
c62f483
to
65c495d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all,
this pull request resolves the lando/lando issue #3373 (lando/lando#3373).
It does so by using the "docker compose config" command to resolve all paths relative to the lando compose file root.
I also have some other (opinionated) changes in this PR, so please let me know what you think about them.
Feel free to just drop commits that do not work (my guess would be the docker compose v2 seperator change could be such a thing, as its not backwards compatible?)
Would love a conversation on the changes or if I maybe should start with a smaller pull request will less changes?
We are using this feature extensively in our project at work and I would love to get this merged. Currently, I am maintaining a fork. Maybe some of the features could also implemented as a plugin, did not really think about that till now.
Thanks for any feedback,
Flo