fix certs test and assess impact of upsteam.appMount removal

builders/lando-v4.js

@@ -9,6 +9,10 @@ const write = require('../utils/write-file');
 const toPosixPath = require('../utils/to-posix-path');
 
 const states = {APP: 'UNBUILT'};
+const stages = {
+  app: 'Commands to build an application.',
+  workers: 'Background processes for whatever else?',
+};
 const groups = {
   'boot': {
     description: 'Required packages that every subsequent group needs',
@@ -236,9 +240,6 @@ module.exports = {
       // consolidate user info with any incoming stuff
       const user = merge({}, {gid, uid, name: username}, require('../utils/parse-v4-user')(config.user));
 
-      // add some upstream stuff and legacy stuff
-      // @NOTE: does this actually do something?
-      upstream.appMount = config['app-mount'].destination;
       // this will change but for right now i just need the image stuff to passthrough
       upstream.config = {image: config.image, ports: config.ports};
       // make sure we also pass the user
@@ -252,7 +253,7 @@ module.exports = {
       };
 
       // get this
-      super(id, merge({}, {groups}, {states}, upstream), app, lando);
+      super(id, merge({}, {stages}, {groups}, {states}, upstream), app, lando);
 
       // props
       this.canExec = true;

examples/certs/README.md

@@ -60,7 +60,7 @@ lando exec web4 -- cat /etc/lando/certs/cert.crt
 lando exec web4 -- cat /etc/lando/certs/cert.key
 
 # Should not generate certs if certs is disable-y
-lando exec web5 -- ls -lsa /etc/lando/certs || echo $? | grep 1
+lando exec web5 -- ls -lsa /etc/lando/certs || echo $? | grep 2
 
 # Should have the correct cert issuer
 lando certinfo | grep Issuer | grep "Lando Development CA"

examples/mounts/README.md

@@ -0,0 +1,32 @@
+# Mounts Example
+
+This example exists primarily to test the following documentation:
+
+* [Lando 4 Service Mounts](TBD)
+
+See the [Landofiles](https://docs.lando.dev/config/lando.html) in this directory for the exact magicks.
+
+## Start up tests
+
+```bash
+# Should start successfully
+lando poweroff
+lando start
+```
+
+## Verification commands
+
+Run the following commands to verify things work as expected
+
+```bash
+# Should test something
+skip
+```
+
+## Destroy tests
+
+```bash
+# Should destroy and poweroff
+lando destroy -y
+lando poweroff
+```