Skip to content

Commit

Permalink
first pass on lando 4 service storage part 2
Browse files Browse the repository at this point in the history
  • Loading branch information
pirog committed Jul 29, 2024
1 parent 2ce43ca commit 4d97a46
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
7 changes: 6 additions & 1 deletion builders/lando-v4.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ module.exports = {
'ssh-agent': true,
'sudo': true,
},
'persistent-storage': [],
'overrides': {},
'ports': [],
'security': {
Expand All @@ -69,6 +70,7 @@ module.exports = {
'cas': [],
'certificate-authorities': [],
},
'storage': [],
},
},
router: () => ({}),
Expand Down Expand Up @@ -208,7 +210,10 @@ module.exports = {
this.router = upstream.router;
this.security = config.security;
this.security.cas.push(caCert, path.join(path.dirname(caCert), `${caDomain}.pem`));
this.storage = require('../utils/normalize-storage')(config.storage, this);
this.storage = [
...require('../utils/normalize-storage')(config.storage, this),
...require('../utils/normalize-storage')(config['persistent-storage'], this),
];
this.user = user;

// top level stuff
Expand Down
8 changes: 4 additions & 4 deletions hooks/app-run-v4-destroy-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ module.exports = async (app, lando) => {
const tasks = services.map(service => {
const container = [app.project, service.id, '1'].join(lando.config.orchestratorSeparator);
return {
title: `Image for ${container}`,
title: `Container ${container}`,
task: async (ctx, task) => {
try {
await service.destroy();
Expand All @@ -40,10 +40,10 @@ module.exports = async (app, lando) => {
await app.runTasks(tasks, {
renderer: 'dc2',
rendererOptions: {
header: 'Destroying',
header: 'Clean Up',
states: {
COMPLETED: 'Destroyed',
STARTED: 'Destroying',
COMPLETED: 'Cleaned',
STARTED: 'Cleaning',
FAILED: 'FAILED',
},
},
Expand Down

0 comments on commit 4d97a46

Please sign in to comment.