-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: build invert index distributely #3452
Open
chenkovsky
wants to merge
11
commits into
lancedb:main
Choose a base branch
from
chenkovsky:feature/paral_fts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3452 +/- ##
==========================================
- Coverage 78.93% 78.78% -0.16%
==========================================
Files 251 251
Lines 92267 93004 +737
Branches 92267 93004 +737
==========================================
+ Hits 72833 73275 +442
- Misses 16463 16752 +289
- Partials 2971 2977 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3269.
I want to build an inverted index for Lance on a distributed system(ray/spark). Currently, I have modified the interface for creating an index to allow an array of fragment IDs to be passed in. If this array is passed in, the index creation interface will return an index object.
I also changed CreateIndex operation definition in python, make it similar to rust version. I don't know why it's different from rust version.
https://www.elastic.co/blog/understanding-query-then-fetch-vs-dfs-query-then-fetch
both query-then-fetch & dfs-query-then-fetch are supported.
query-then-fetch is fast, and not accurate, if the number of texts is big, this mode is good enough, it's also default mode of es.
dfs-query-then-fetch is slow, but accurate. it's very useful if data is skew or small.
next step I also want to do fts query distributely.