Skip to content

Commit

Permalink
feat: expose specifying scanner filters via datafusion (#3458)
Browse files Browse the repository at this point in the history
We are trying to build a Datafusion table provider in LanceDB and it
receives expressions as DF logical exprs. We can go DF expr -> substrait
-> DF expr but it seems simpler to just expose the API to accept filters
as DF exprs directly.
  • Loading branch information
westonpace authored Feb 18, 2025
1 parent 6b58bc1 commit 4a0fb90
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion rust/lance/src/dataset/scanner.rs
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ impl Scanner {
Ok(self)
}

pub(crate) fn filter_expr(&mut self, filter: Expr) -> &mut Self {
pub fn filter_expr(&mut self, filter: Expr) -> &mut Self {
self.filter = Some(LanceFilter::Datafusion(filter));
self
}
Expand Down

0 comments on commit 4a0fb90

Please sign in to comment.