Reading user and instance settings #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcannood
added a commit
that referenced
this pull request
Oct 2, 2024
rcannood
changed the title
rcannood
added a commit
that referenced
this pull request
Oct 4, 2024
* wip porting some lamindb_setup code * experiment with class refactoring * start with new class implementations * implement get_record again * get related fields * connect via lamindb_setup * create instance wrapper function * evaluate functions * merge PR #2 into this branch and refactor * style code * update class diagram * clean up class fields * fix issues with classes * update markdowns * update readme * fix merge * update changelog * undo accidentally committed changes * rename Model to Registry * fix renaming model to registry * fix due to changes in Lamin Hub API * only create the record class once * rename API to InstanceAPI * move assertion to the top of the function * change stop to cli_abort and warning to cli_warn * use consistent naming * directly access the registry classes * update readme * return the registry class instead of having a function to convert a list to a record * create the helper functions in a less roundabout way * use lowercase variable name * rename classes * add roxygen docs to classes * update rbuildignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally entered into a rabbithole porting code from lamindb_setup, something we didn't want to spend time on at this stage.
Instead of deleting the code, I might as well commit the code and create a draft PR. Perhaps we can come back to it at a later stage.