Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 Prettify build.yml and adjust coverage compute if a job isn't run #2361

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

falexwolf
Copy link
Member

No description provided.

@falexwolf falexwolf changed the title ♻️ Prettier 👷 Prettier build.yml Jan 17, 2025
@falexwolf falexwolf changed the title 👷 Prettier build.yml 👷 Prettify build.yml and adjust coverage compute if a job isn't run Jan 17, 2025
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.60%. Comparing base (b5debf1) to head (cf9e5b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2361      +/-   ##
==========================================
- Coverage   91.51%   85.60%   -5.91%     
==========================================
  Files          91       62      -29     
  Lines        9270     8990     -280     
==========================================
- Hits         8483     7696     -787     
- Misses        787     1294     +507     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 17, 2025

@github-actions github-actions bot temporarily deployed to pull request January 17, 2025 13:13 Inactive
@Koncopd
Copy link
Member

Koncopd commented Jan 17, 2025

btw what is with the coverage? Why is it so low now?

@falexwolf
Copy link
Member Author

btw what is with the coverage? Why is it so low now?

curator tests are skipped if no files in curator module are changed; but coverage isn't respecting this; that's what I'm trying to fix here

@github-actions github-actions bot temporarily deployed to pull request January 17, 2025 13:42 Inactive
@falexwolf
Copy link
Member Author

Do you spot why the coveragerc might not be respected, @Zethson?

@Zethson
Copy link
Member

Zethson commented Jan 17, 2025

Settings in a project.toml take precedence I think. Maybe this config is therefore still seen first and the specific one ignored? Not sure, I need to think further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants