Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ Use connect_instance_new for Koncopd, sunnyosun and falexwolf for local testing #851

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

Koncopd
Copy link
Member

@Koncopd Koncopd commented Sep 11, 2024

@Koncopd
Copy link
Member Author

Koncopd commented Sep 11, 2024

Recent PRs in this direction including this one decrease coverage, but it will be compensated when we decide to replace old connect_instance with connect_instance_new (via edge).

Copy link

@github-actions github-actions bot temporarily deployed to pull request September 11, 2024 12:04 Inactive
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.45%. Comparing base (e104ca0) to head (ee08b25).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lamindb_setup/_connect_instance.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #851      +/-   ##
==========================================
- Coverage   83.47%   83.45%   -0.02%     
==========================================
  Files          43       43              
  Lines        3352     3355       +3     
==========================================
+ Hits         2798     2800       +2     
- Misses        554      555       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Koncopd Koncopd merged commit db0d9a0 into main Sep 11, 2024
11 of 12 checks passed
@Koncopd Koncopd deleted the use_connect_edge branch September 11, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant