-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Enableln.connect()
in lamindb
#668
Conversation
ln.setup.connect()
in lamindb
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #668 +/- ##
==========================================
- Coverage 82.17% 80.89% -1.29%
==========================================
Files 39 38 -1
Lines 2312 2340 +28
==========================================
- Hits 1900 1893 -7
- Misses 412 447 +35 ☔ View full report in Codecov by Sentry. |
ln.setup.connect()
in lamindbln.connect()
in lamindb
setting cache should work for all instances, it sets the cache folder for all instances, not for the current one only, so it should not be commented out, if it is broken, then it is a genuine bug, i believe. |
|
||
if _LAMINDB_CONNECTED_TO is not None: | ||
return True | ||
if IS_SETUP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Koncopd - this line makes it more rigorous because this measures whether django is setup or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is why now, we need the _test
flag. I will try this.
(Just confirming what you said on the call before!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it and it doesn't work because it doesn't attempt to access the SQLite file when run with _test
. Let's see whether I can change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this should not matter, lock is called in _load_db
, which is called always on load / connect.
No description provided.