Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore tests that involve ln_setup.connect() #669

Open
falexwolf opened this issue Mar 7, 2024 · 5 comments
Open

Restore tests that involve ln_setup.connect() #669

falexwolf opened this issue Mar 7, 2024 · 5 comments

Comments

@falexwolf
Copy link
Member

We have a few tests that call ln_setup.connect() (aka ln_setup.load()) repeatedly in the same Python session.

These tests were enabled by calling ln_setup.close(), but this never actually shut down the Django session.

Unfortunately, we can currently not switch between different instances in the same Python session.

@Koncopd
Copy link
Member

Koncopd commented Mar 7, 2024

@falexwolf could you write the tests' names to be fixed / restored?

@falexwolf
Copy link
Member Author

There are two instances of this.

One instance is here:
image

The second instance is here:
image

I'm thinking very hard about bringing back the ability to connect to different instances in the same Python session, and then we could simply uncomment these tests.

Maybe I can make it work very soon, but I'm still not sure.

@Koncopd
Copy link
Member

Koncopd commented Mar 7, 2024

Both tests worked fine. What changed?

@Koncopd
Copy link
Member

Koncopd commented Mar 7, 2024

Actually connect should throw an error if a cloud sqlite instance is locked.

@falexwolf
Copy link
Member Author

I'm trying to restore tests but this doesn't work:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants