Merge pull request #94 from boesing/feature/benchmark-has-performance

qa: add benchmark for `ServiceManager::has`
laminas · Jul 24, 2021 · 578554f · 578554f
2 parents c44bac1 + d6e7fe4
commit 578554f
Show file tree

Hide file tree

Showing 17 changed files with 334 additions and 118 deletions.
diff --git a/benchmarks/BenchAsset/AbstractFactoryFoo.php b/benchmarks/BenchAsset/AbstractFactoryFoo.php
@@ -7,16 +7,18 @@
 
 class AbstractFactoryFoo implements AbstractFactoryInterface
 {
-    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
+    /** {@inheritDoc} */
+    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
     {
         if ($requestedName === 'foo') {
             return new Foo($options);
         }
         return false;
     }
 
+    /** {@inheritDoc} */
     public function canCreate(ContainerInterface $container, $requestedName)
     {
-        return ($requestedName === 'foo');
+        return $requestedName === 'foo';
     }
 }
diff --git a/benchmarks/BenchAsset/Bar.php b/benchmarks/BenchAsset/Bar.php
@@ -4,8 +4,10 @@
 
 class Bar
 {
+    /** @var mixed */
     protected $options;
 
+    /** @param mixed $options */
     public function __construct($options = null)
     {
         $this->options = $options;

diff --git a/benchmarks/BenchAsset/FactoryFoo.php b/benchmarks/BenchAsset/FactoryFoo.php
@@ -7,7 +7,8 @@
 
 class FactoryFoo implements FactoryInterface
 {
-    public function __invoke(ContainerInterface $container, $requestedName, array $options = null)
+    /** {@inheritDoc} */
+    public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null)
     {
         return new Foo($options);
     }

diff --git a/benchmarks/BenchAsset/Foo.php b/benchmarks/BenchAsset/Foo.php
@@ -4,8 +4,10 @@
 
 class Foo
 {
+    /** @var mixed */
     protected $options;
 
+    /** @param mixed $options */
     public function __construct($options = null)
     {
         $this->options = $options;

diff --git a/benchmarks/BenchAsset/ServiceDependingOnConfig.php b/benchmarks/BenchAsset/ServiceDependingOnConfig.php
@@ -4,10 +4,8 @@
 
 class ServiceDependingOnConfig
 {
-    /**
-     * @var array
-     */
-    private $config;
+    /** @var array */
+    public $config;
 
     public function __construct(array $config)
     {

diff --git a/benchmarks/BenchAsset/ServiceWithDependency.php b/benchmarks/BenchAsset/ServiceWithDependency.php
@@ -4,14 +4,9 @@
 
 class ServiceWithDependency
 {
-    /**
-     * @var Dependency
-     */
-    private $dependency;
+    /** @var Dependency */
+    protected $dependency;
 
-    /**
-     * @param Dependency $dependency
-     */
     public function __construct(Dependency $dependency)
     {
         $this->dependency = $dependency;

diff --git a/benchmarks/FetchCachedServicesBench.php b/benchmarks/FetchCachedServicesBench.php
@@ -6,6 +6,7 @@
 use PhpBench\Benchmark\Metadata\Annotations\Iterations;
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
+use stdClass;
 
 /**
  * @Revs(1000)
@@ -14,31 +15,29 @@
  */
 class FetchCachedServicesBench
 {
-    /**
-     * @var ServiceManager
-     */
+    /** @var ServiceManager */
     private $sm;
 
     public function __construct()
     {
         $this->sm = new ServiceManager([
-            'factories' => [
+            'factories'          => [
                 'factory1' => BenchAsset\FactoryFoo::class,
             ],
-            'invokables' => [
+            'invokables'         => [
                 'invokable1' => BenchAsset\Foo::class,
             ],
-            'services' => [
-                'service1' => new \stdClass(),
+            'services'           => [
+                'service1' => new stdClass(),
             ],
-            'aliases' => [
+            'aliases'            => [
                 'alias1'          => 'service1',
                 'recursiveAlias1' => 'alias1',
                 'recursiveAlias2' => 'recursiveAlias1',
             ],
             'abstract_factories' => [
-                BenchAsset\AbstractFactoryFoo::class
-            ]
+                BenchAsset\AbstractFactoryFoo::class,
+            ],
         ]);
 
         // forcing initialization of all the services
@@ -50,55 +49,55 @@ public function __construct()
         $this->sm->get('recursiveAlias2');
     }
 
-    public function benchFetchFactory1()
+    public function benchFetchFactory1(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;
 
         $sm->get('factory1');
     }
 
-    public function benchFetchInvokable1()
+    public function benchFetchInvokable1(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;
 
         $sm->get('invokable1');
     }
 
-    public function benchFetchService1()
+    public function benchFetchService1(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;
 
         $sm->get('service1');
     }
 
-    public function benchFetchAlias1()
+    public function benchFetchAlias1(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;
 
         $sm->get('alias1');
     }
 
-    public function benchFetchRecursiveAlias1()
+    public function benchFetchRecursiveAlias1(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;
 
         $sm->get('recursiveAlias1');
     }
 
-    public function benchFetchRecursiveAlias2()
+    public function benchFetchRecursiveAlias2(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;
 
         $sm->get('recursiveAlias2');
     }
 
-    public function benchFetchAbstractFactoryService()
+    public function benchFetchAbstractFactoryService(): void
     {
         // @todo @link https://github.com/phpbench/phpbench/issues/304
         $sm = clone $this->sm;

diff --git a/benchmarks/FetchNewServiceManagerBench.php b/benchmarks/FetchNewServiceManagerBench.php
@@ -6,6 +6,7 @@
 use PhpBench\Benchmark\Metadata\Annotations\Iterations;
 use PhpBench\Benchmark\Metadata\Annotations\Revs;
 use PhpBench\Benchmark\Metadata\Annotations\Warmup;
+use stdClass;
 
 /**
  * @Revs(100)
@@ -14,11 +15,9 @@
  */
 class FetchNewServiceManagerBench
 {
-    const NUM_SERVICES = 1000;
+    private const NUM_SERVICES = 1000;
 
-    /**
-     * @var array
-     */
+    /** @var array */
     private $config = [];
 
     public function __construct()
@@ -33,7 +32,7 @@ public function __construct()
             ],
         ];
 
-        $service = new \stdClass();
+        $service = new stdClass();
 
         for ($i = 0; $i <= self::NUM_SERVICES; $i++) {
             $config['factories']["factory_$i"]    = BenchAsset\FactoryFoo::class;
@@ -44,7 +43,7 @@ public function __construct()
         $this->config = $config;
     }
 
-    public function benchFetchServiceManagerCreation()
+    public function benchFetchServiceManagerCreation(): void
     {
         new ServiceManager($this->config);
     }

diff --git a/benchmarks/FetchNewServiceUsingConfigAbstractFactoryAsFactoryBench.php b/benchmarks/FetchNewServiceUsingConfigAbstractFactoryAsFactoryBench.php
@@ -15,19 +15,17 @@
  */
 class FetchNewServiceUsingConfigAbstractFactoryAsFactoryBench
 {
-    /**
-     * @var ServiceManager
-     */
+    /** @var ServiceManager */
     private $sm;
 
     public function __construct()
     {
         $this->sm = new ServiceManager([
-            'services' => [
+            'services'  => [
                 'config' => [
                     ConfigAbstractFactory::class => [
-                        BenchAsset\Dependency::class => [],
-                        BenchAsset\ServiceWithDependency::class => [
+                        BenchAsset\Dependency::class               => [],
+                        BenchAsset\ServiceWithDependency::class    => [
                             BenchAsset\Dependency::class,
                         ],
                         BenchAsset\ServiceDependingOnConfig::class => [
@@ -37,49 +35,49 @@ public function __construct()
                 ],
             ],
             'factories' => [
-                BenchAsset\Dependency::class => ConfigAbstractFactory::class,
-                BenchAsset\ServiceWithDependency::class => ConfigAbstractFactory::class,
+                BenchAsset\Dependency::class               => ConfigAbstractFactory::class,
+                BenchAsset\ServiceWithDependency::class    => ConfigAbstractFactory::class,
                 BenchAsset\ServiceDependingOnConfig::class => ConfigAbstractFactory::class,
             ],
         ]);
     }
 
-    public function benchFetchServiceWithNoDependencies()
+    public function benchFetchServiceWithNoDependencies(): void
     {
         $sm = clone $this->sm;
 
         $sm->get(BenchAsset\Dependency::class);
     }
 
-    public function benchBuildServiceWithNoDependencies()
+    public function benchBuildServiceWithNoDependencies(): void
     {
         $sm = clone $this->sm;
 
         $sm->build(BenchAsset\Dependency::class);
     }
 
-    public function benchFetchServiceDependingOnConfig()
+    public function benchFetchServiceDependingOnConfig(): void
     {
         $sm = clone $this->sm;
 
         $sm->get(BenchAsset\ServiceDependingOnConfig::class);
     }
 
-    public function benchBuildServiceDependingOnConfig()
+    public function benchBuildServiceDependingOnConfig(): void
     {
         $sm = clone $this->sm;
 
         $sm->build(BenchAsset\ServiceDependingOnConfig::class);
     }
 
-    public function benchFetchServiceWithDependency()
+    public function benchFetchServiceWithDependency(): void
     {
         $sm = clone $this->sm;
 
         $sm->get(BenchAsset\ServiceWithDependency::class);
     }
 
-    public function benchBuildServiceWithDependency()
+    public function benchBuildServiceWithDependency(): void
     {
         $sm = clone $this->sm;
 

diff --git a/benchmarks/FetchNewServiceUsingReflectionAbstractFactoryAsFactoryBench.php b/benchmarks/FetchNewServiceUsingReflectionAbstractFactoryAsFactoryBench.php
@@ -15,61 +15,59 @@
  */
 class FetchNewServiceUsingReflectionAbstractFactoryAsFactoryBench
 {
-    /**
-     * @var ServiceManager
-     */
+    /** @var ServiceManager */
     private $sm;
 
     public function __construct()
     {
         $this->sm = new ServiceManager([
-            'services' => [
+            'services'  => [
                 'config' => [],
             ],
             'factories' => [
-                BenchAsset\Dependency::class => ReflectionBasedAbstractFactory::class,
-                BenchAsset\ServiceWithDependency::class => ReflectionBasedAbstractFactory::class,
+                BenchAsset\Dependency::class               => ReflectionBasedAbstractFactory::class,
+                BenchAsset\ServiceWithDependency::class    => ReflectionBasedAbstractFactory::class,
                 BenchAsset\ServiceDependingOnConfig::class => ReflectionBasedAbstractFactory::class,
             ],
         ]);
     }
 
-    public function benchFetchServiceWithNoDependencies()
+    public function benchFetchServiceWithNoDependencies(): void
     {
         $sm = clone $this->sm;
 
         $sm->get(BenchAsset\Dependency::class);
     }
 
-    public function benchBuildServiceWithNoDependencies()
+    public function benchBuildServiceWithNoDependencies(): void
     {
         $sm = clone $this->sm;
 
         $sm->build(BenchAsset\Dependency::class);
     }
 
-    public function benchFetchServiceDependingOnConfig()
+    public function benchFetchServiceDependingOnConfig(): void
     {
         $sm = clone $this->sm;
 
         $sm->get(BenchAsset\ServiceDependingOnConfig::class);
     }
 
-    public function benchBuildServiceDependingOnConfig()
+    public function benchBuildServiceDependingOnConfig(): void
     {
         $sm = clone $this->sm;
 
         $sm->build(BenchAsset\ServiceDependingOnConfig::class);
     }
 
-    public function benchFetchServiceWithDependency()
+    public function benchFetchServiceWithDependency(): void
     {
         $sm = clone $this->sm;
 
         $sm->get(BenchAsset\ServiceWithDependency::class);
     }
 
-    public function benchBuildServiceWithDependency()
+    public function benchBuildServiceWithDependency(): void
     {
         $sm = clone $this->sm;