-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to support PHP 8.3 #53
Conversation
This commit updates several dependencies in the composer.lock. Key updates include removing 'container-interop/container-interop', and upgrading 'laminas/laminas-servicemanager', 'laminas/laminas-stdlib' and 'doctrine/instantiator' among others. These upgrades ensure better compatibility and performance with newer versions of PHP. Signed-off-by: Sebastian Hopfe <[email protected]>
The Laminas library has been updated to the latest version, which includes various dependency updates. Additionally, improvements have been made to the test suite by adding more attributes to classes for better readability and maintainability. The new attributes will help track the state and behavior of instances throughout tests. The tests will be more independent and easier to understand as a result. Signed-off-by: Sebastian Hopfe <[email protected]>
The Laminas' version requirement has been updated to "^3.21.0" from "^3.3.0", ensuring compatibility with its latest release. This version upgrade includes various dependency updates that will improve system's performance and stability. Signed-off-by: Sebastian Hopfe <[email protected]>
6df6775
to
14881f7
Compare
@weierophinney - I don't know why the errors in the codestyle check fail, I haven't adjusted anything else. I only had to adapt the tests because the corresponding test trait was adapted through the PHPUnit 10 integration in the ServiceManager. This resulted in a drop of PHP 8.0 for me - which is now obsolete anyway |
Blocked by: laminas/laminas-db#293 |
It's because you ran a Do the following:
These should be done anyways, and doing it during a PHP minor bump is a great time to do it. |
Signed-off-by: Sebastian Hopfe <[email protected]>
Signed-off-by: Sebastian Hopfe <[email protected]>
@weierophinney The fact that I have already raised the service manager to ^3.21 obviously explains the error. I now have all pipes clean, except for the fact that laminas-db still needs a release. |
@weierophinney |
@froschdesign The reason laminas/laminas-validator#205 went through is probably this change here: |
@steffendietz |
Signed-off-by: Sebastian Hopfe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @nusphere!
This commit updates several dependencies in the composer.lock. Key updates include removing 'container-interop/container-interop', and upgrading 'laminas/laminas-servicemanager', 'laminas/laminas-stdlib' and 'doctrine/instantiator' among others. These upgrades ensure better compatibility and performance with newer versions of PHP.
Description
This PR allow to install this package with PHP 8.3. Since the there is a dev requirement to
laminas/laminas-db
- the PR laminas/laminas-db#293 is required