Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add additional headers_sent informations to the EmitterException #17

Merged

Conversation

boesing
Copy link
Member

@boesing boesing commented Jul 8, 2021

Q A
BC Break yes
New Feature yes

Description

The headers_sent function has optional $filename and $line arguments which can be passed by reference.
This was inspired by #1

Closes #1

@boesing boesing added this to the 2.0.0 milestone Jul 8, 2021
@boesing
Copy link
Member Author

boesing commented Jul 8, 2021

$filename = null;
$line = null;
if (headers_sent($filename, $line)) {
assert(is_string($filename) && is_int($line));
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boesing boesing force-pushed the feature/headers-sent-additional-informations branch from 48ccc97 to 8f8f4e0 Compare July 12, 2021 14:46
…ception`

The `headers_sent` function has optional `$filename` and `$line` arguments which can be passed by reference.

Closes laminas#1

Signed-off-by: Maximilian Bösing <[email protected]>
@boesing boesing merged commit e70fab8 into laminas:2.0.x Jul 12, 2021
@boesing boesing deleted the feature/headers-sent-additional-informations branch July 12, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract extra info from headers_sent
1 participant