Skip to content

Commit

Permalink
Merge pull request #280 from fezfez/php8.3
Browse files Browse the repository at this point in the history
Adds PHP 8.3 as new supported version
  • Loading branch information
boesing authored Nov 6, 2023
2 parents 76cc49a + 7ad2133 commit 66cf9a2
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 17 deletions.
5 changes: 4 additions & 1 deletion .laminas-ci.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,8 @@
"apc.enabled=1",
"apc.enable_cli=1"
],
"backwardCompatibilityCheck": true
"backwardCompatibilityCheck": true,
"ignore_php_platform_requirements": {
"8.3": true
}
}
4 changes: 2 additions & 2 deletions .laminas-ci/install-apcu-extension-via-pecl.sh
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@

PHP_VERSION="$1"

if ! [[ "${PHP_VERSION}" =~ 8\.2 ]]; then
echo "APCu is only installed from pecl for PHP 8.2, ${PHP_VERSION} detected."
if ! [[ "${PHP_VERSION}" =~ 8\.3 ]]; then
echo "APCu is only installed from pecl for PHP 8.3, ${PHP_VERSION} detected."
exit 0;
fi

Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
}
},
"require": {
"php": "~8.1.0 || ~8.2.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"laminas/laminas-cache-storage-implementation": "1.0",
"laminas/laminas-eventmanager": "^3.4",
"laminas/laminas-servicemanager": "^3.21",
Expand Down
6 changes: 3 additions & 3 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions psalm-baseline.xml
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,6 @@
<code>setDirPermission</code>
<code>setFileLocking</code>
<code>setFilePermission</code>
<code>setIndexFilename</code>
<code>setObject</code>
<code>setObjectCacheMagicProperties</code>
<code>setObjectCacheMethods</code>
Expand Down Expand Up @@ -851,9 +850,6 @@
</UndefinedInterfaceMethod>
</file>
<file src="test/Pattern/CaptureCacheTest.php">
<MixedMethodCall>
<code>setIndexFilename</code>
</MixedMethodCall>
<PossiblyNullArrayAccess>
<code><![CDATA[$err['message']]]></code>
<code><![CDATA[$err['message']]]></code>
Expand All @@ -866,12 +862,6 @@
<code>set</code>
<code>set</code>
</UndefinedInterfaceMethod>
<UndefinedThisPropertyAssignment>
<code><![CDATA[$this->options]]></code>
</UndefinedThisPropertyAssignment>
<UndefinedThisPropertyFetch>
<code><![CDATA[$this->options]]></code>
</UndefinedThisPropertyFetch>
</file>
<file src="test/Pattern/ObjectCacheTest.php">
<MissingClosureParamType>
Expand Down
3 changes: 3 additions & 0 deletions test/Pattern/AbstractCommonPatternTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ abstract class AbstractCommonPatternTest extends TestCase
/** @var PatternInterface */
protected $pattern;

/** @var PatternOptions */
protected $options;

protected function setUp(): void
{
self::assertInstanceOf(
Expand Down

0 comments on commit 66cf9a2

Please sign in to comment.