Refactor Python's bn254 module #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…compiles into add_eth_tests
Co-authored-by: Nacho Avecilla <[email protected]>
Co-authored-by: Nacho Avecilla <[email protected]>
Co-authored-by: Nacho Avecilla <[email protected]>
* Finish fp2 arithmetic * Add more precomputed values * Fix fp2 inv * Add EOF * Rename module
* Finish fp2 arithmetic * Add more precomputed values * Add arithmetic operations for fp6 * Update constant name Co-authored-by: Ivan Litteri <[email protected]> * Replace epsilon for XI * Change script name * Add multiplication by xi in fp2 and fp6 * Add alternative inverse method * Fix inverse operation --------- Co-authored-by: Iván Litteri <[email protected]> Co-authored-by: Ivan Litteri <[email protected]>
* WIP * add fp12 arithmetics * fix typo * add addition tests * add sub test * rename gamma function * add mul tests * fix function call * fix typo * mul fixes * fix mul by 1 * fix square * fix fp12 inverse * add multiply by 2 asserts * add EOF --------- Co-authored-by: Iván Litteri <[email protected]>
* Rename file * Add implementation for jacobian projective coordinates * Fix fp12 merge error * Fix addition * Rename function to check inifinity and add extra comments
* Add fp2 arithmetics * Add fp6 arithmetics * Rename funcs * Fix compilation errors in fp6 operations * Add tests for inverse and sub for fp2 * Fix square and multiplication for fp6 * Add tests for add, mul, sub and square in fp6 * add fp12 arithmetic * Fix inverse in fp6 * Add tests for inverse in fp6 * add fp12 tests * add inverse test for fp12 * changes mul for sub --------- Co-authored-by: Iván Litteri <[email protected]> Co-authored-by: Joaquin Carletti <[email protected]>
* Move point doubling and line evaluation to pairing file * Change return type in point adding and line evaluation to match with doubling * Remove incorrect parameter * Change name to match with other pairing function
* Change fp6 return type to single tuple * change return to single tuple --------- Co-authored-by: Joaquin Carletti <[email protected]>
* add millers loop basics * add PI functions to loop * add neg of a G2 point * add loop counter * fix return of negate funciton * fix loop_counter values * rename utils file * fix imports * change constants to fp6 file * fix miller loop set up * add comment * fix comment * fix typo
* Add ten in montgomery form as constant * Add frobenius operations * Add negate operation for fp6 * Add conjugate operation for fp2 * Add operations in fp2 used in final exponentiation * Add final exponentiation function * Fix return types to match with new changes * Add corrections to n_square function * Use montgomery for gamma factors and add frobenius tests * Add test for cyclotomic square * Add another final exponentiation implementation and test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some module errors in
bn254_py/pointneed to be handled before mergingProposed structure
bn254_py/ ├── fp.py ├── fp2.py ├── fp6.py ├── fp12.py ├── g2.py (probable need to be inside points/) ├── frobenius.py ├──montgomery.py ├── pairing_utils.py ├── pairing.py └── point/ ├── affine.py ├── homogeneous_projective.py └── jacobian_projective.py