feat(eigen-client-m0-implementation): grafana metrics #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianbelinche
requested changes
Nov 11, 2024
Comment on lines
25
to
33
| git::add_remote( | ||
| shell, | ||
| path_to_era_observability.clone(), | ||
| "lambda", | ||
| "https://github.com/lambdaclass/era-observability.git", | ||
| )?; | ||
| git::checkout(shell, path_to_era_observability.clone(), "eigenda")?; | ||
|
|
||
| spinner.finish(); |
There was a problem hiding this comment.
I think the idea is to not do this, that is why we have a PR to era-observability
There was a problem hiding this comment.
If that's the case then an temporary step should be added to the instructions, specifying how to checkout to the needed branch while said PR remains unmerged.
There was a problem hiding this comment.
Let's add that and remove that code then!
Base automatically changed from
eigen-client-m0-concurrent-dispatcher
to
eigen-client-m0-implementation
November 12, 2024 13:20
juanbono
approved these changes
Nov 12, 2024
* Add shutdown to dispatch batches * Add JoinSet * Format code * Fix unbounded channel breaking authenticated dispersal * Fix pr comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
Implement grafana metrics for data availability dispatcher
Checklist
zkstack dev fmtandzkstack dev lint.