Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eigen-client-extra-features): get inclusion data #324

Merged
merged 1 commit into from
Nov 1, 2024
Merged

feat(eigen-client-extra-features): get inclusion data #324

merged 1 commit into from
Nov 1, 2024

Conversation

juan518munoz
Copy link

What ❔

Implement inclusion data retrieval for the Eigen DA client.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@juan518munoz juan518munoz mentioned this pull request Nov 1, 2024
Closed
12 tasks
gianbelinche
gianbelinche approved these changes Nov 1, 2024
View reviewed changes
Copy link

@gianbelinche gianbelinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juanbono juanbono merged commit 5b8665b into eigen-client-extra-features Nov 1, 2024
14 of 25 checks passed
@juanbono juanbono deleted the eigen-client-get-inclusion-data branch November 1, 2024 23:29
@juanbono juanbono mentioned this pull request Nov 8, 2024
Open
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gianbelinche gianbelinche gianbelinche approved these changes

@juanbono juanbono juanbono approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juan518munoz @juanbono @gianbelinche